Skip to content

Change experimenter from glean-core to glean-server #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change experimenter from glean-core to glean-server #961

wants to merge 1 commit into from

Conversation

@relud
Copy link
Contributor

@relud relud commented Nov 3, 2025

experimenter is switching to server-side glean in mozilla/experimenter#13859

@badboy
Copy link
Member

badboy commented Nov 4, 2025

The dry-run looks good:

python3 -m probe_scraper.runner --dry-run --cache-dir tmp/cache --out-dir tmp/out --glean --glean-limit-date 2025-11-02 --output-bucket=gs://probe-scraper-prod-artifacts/ --glean-url https://github.com/mozilla/experimenter --glean-url https://github.com/mozilla/glean_parser

afau this should all work just fine: glean-server is not a full glean, but it does have the events ping, so that table will be re-used. the other existing tables won't be used.
I will verify that this "won't be used" is fine or if that results in automatic deletion or something.

@akkomar
Copy link
Contributor

akkomar commented Nov 4, 2025

(...) I will verify that this "won't be used" is fine or if that results in automatic deletion or something.

This will trigger deletions. Glean-server declares only events ping (https://github.com/mozilla/glean_parser/blob/main/server_telemetry/server-side-pings.yaml), so other pings currently inherited from glean-core (https://dictionary.telemetry.mozilla.org/apps/experimenter_backend?itemType=pings&page=1) - baseline, deletion-request, health, metrics - will disappear in schema generation. This will cause schema generator to fail and production schema deploys to stop.

If these pings were not used and removal of their tables is desired (@relud?)we can add them to https://github.com/mozilla/mozilla-schema-generator/blob/main/incompatibility-allowlist to allow that.

@relud
Copy link
Contributor Author

relud commented Nov 4, 2025

yeah those tables should be deleted

@relud
Copy link
Contributor Author

relud commented Nov 4, 2025

filed mozilla/mozilla-schema-generator#299 to allow the deletes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@badboy badboy badboy approved these changes

@chutten chutten Awaiting requested review from chutten chutten is a code owner

@akkomar akkomar Awaiting requested review from akkomar akkomar is a code owner

@whd whd Awaiting requested review from whd whd is a code owner

@mikaeld mikaeld Awaiting requested review from mikaeld mikaeld is a code owner

@Dexterp37 Dexterp37 Awaiting requested review from Dexterp37 Dexterp37 is a code owner

@travis79 travis79 Awaiting requested review from travis79 travis79 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@relud @badboy @akkomar